Skip to content

[ExtractAPI] Cherry-pick multiple correctness fixes #10882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

snprajwal
Copy link

@snprajwal snprajwal commented Jun 20, 2025

Cherry-pick of the following PRs:

@snprajwal snprajwal requested a review from a team as a code owner June 20, 2025 22:27
@QuietMisdreavus
Copy link

@swift-ci Please test

snprajwal added 4 commits July 9, 2025 13:28
ObjC methods include a +/- prefix to indicate if they are a class or
instance method. This information is valuable, and must be included in
the navigator generated by ExtractAPI.

rdar://150870936
This information was being left out of the symbol graph.

rdar://131780883
Pointer types in function signatures must place the asterisk before the
identifier without a space in between. This patch removes the space and
also ensures that pointers to pointers are formatted correctly.

rdar://131780418
rdar://154533037
The subheading for a destructor contained only the identifier. The tilde
must also be included as it is necessary to differentiate the destructor
from any constructors present.

rdar://129587608
@snprajwal snprajwal changed the title [ExtractAPI] Include +/- symbols for ObjC methods (#145035) [ExtractAPI] Cherry-pick multiple correctness fixes Jul 9, 2025
@snprajwal
Copy link
Author

Closing this as it has been deferred to a later release

@snprajwal snprajwal closed this Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants